Fix misuse of CMAKE_SIZEOF_VOID_P in testing
#79095
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kntkymt
commented
Feb 1, 2025
There was a problem hiding this comment.
[note for reviewers] Since it seems we didn't use the flag in this file, let me remove it instead of fixing the flag.
kntkymt
changed the title
CMAKE_SIZEOF_VOID in testingCMAKE_SIZEOF_VOID_P in testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are a few instances of misuse of
CMAKE_SIZEOF_VOID_Pin test files. This flag is intended to represent the byte size of a word, but we mistakenly pass%target-ptrsize(which is bits size of a word) to it.Fortunately, it does not seem to affect the test results. However, we should fix this to prevent similar mistakes in the future.
Solution
Use
WORD_BITSinstead.Alternative Considered
-DCMAKE_SIZEOF_VOID_P=$((%target-ptrsize/8))works too but it seems we used the value to making bits representation of word (it's redundant), it would be better to useWORD_BITSin these situation (especially in testing files).